-
Notifications
You must be signed in to change notification settings - Fork 96
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the Googlers can find more info about SignCLA and this PR by following this link. |
4d6b113
to
b91ed61
Compare
650e43a
to
6a0fbfb
Compare
f6c20a6
to
9322243
Compare
0524145
to
c239233
Compare
5161d32
to
3b28a7f
Compare
3b28a7f
to
e789e46
Compare
PR has been edited👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
==========================================
+ Coverage 94.88% 94.91% +0.02%
==========================================
Files 140 140
Lines 9293 9294 +1
Branches 671 671
==========================================
+ Hits 8818 8821 +3
+ Misses 475 473 -2
Continue to review full report at Codecov.
|
Fixed the build, tests got impacted because of googleapis/gcp-metadata#117 @draffensperger @justindsmith can you please review and approve. |
This PR contains the following updates:
^0.9.3
->^1.0.0
Release Notes
googleapis/gcp-metadata
v1.0.0
Compare Source
02-14-2019 16:00 PST
Bug Fixes
Documentation
Internal / Testing Changes
Renovate configuration
📅 Schedule: "after 9am and before 3pm" (UTC).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "
rebase!
".🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot. View repository job log here.