Fix: silently ignore the invalid keys and values (#664)

census-instrumentation · Oct 9, 2019 · 24db9ed · 24db9ed
1 parent ae226fa
commit 24db9ed
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 14 deletions.
diff --git a/packages/opencensus-core/src/tags/tag-map.ts b/packages/opencensus-core/src/tags/tag-map.ts
@@ -42,12 +42,7 @@ export class TagMap {
    * @param tagMetadata The TagMetadata associated with this Tag.
    */
   set(tagKey: TagKey, tagValue: TagValue, tagMetadata?: TagMetadata): void {
-    if (!isValidTagKey(tagKey)) {
-      throw new Error(`Invalid TagKey name: ${tagKey.name}`);
-    }
-    if (!isValidTagValue(tagValue)) {
-      throw new Error(`Invalid TagValue: ${tagValue.value}`);
-    }
+    if (!isValidTagKey(tagKey) || !isValidTagValue(tagValue)) return;
     let existingKey;
     for (const key of this.registeredTags.keys()) {
       if (key.name === tagKey.name) {

diff --git a/packages/opencensus-core/test/test-tag-map.ts b/packages/opencensus-core/test/test-tag-map.ts
@@ -75,16 +75,16 @@ describe('TagMap()', () => {
       assert.deepStrictEqual(tags.get(key1), expectedTagValueWithMetadata);
     });
 
-    it('should throw an error when invalid tagKey', () => {
-      assert.throws(() => {
-        tagMap.set(invalidKey1, value1);
-      }, /^Error: Invalid TagKey name:/);
+    it('should silently ignore when invalid tagKey', () => {
+      tagMap.set(invalidKey1, value1);
+      const tags = tagMap.tagsWithMetadata;
+      assert.strictEqual(tags.size, 0);
     });
 
-    it('should throw an error when invalid tagValue', () => {
-      assert.throws(() => {
-        tagMap.set(key1, invalidValue1);
-      }, /^Error: Invalid TagValue:/);
+    it('should silently ignore when invalid tagValue', () => {
+      tagMap.set(key1, invalidValue1);
+      const tags = tagMap.tagsWithMetadata;
+      assert.strictEqual(tags.size, 0);
     });
 
     it('should not set duplicate tagkey and tagvalue', () => {