This repository has been archived by the owner on Dec 23, 2023. It is now read-only.
Add a warning about try-with-resource to auto-close spans. #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1362 +/- ##
========================================
Coverage 83.2% 83.2%
Complexity 1393 1393
========================================
Files 221 221
Lines 6586 6586
Branches 620 620
========================================
Hits 5480 5480
Misses 930 930
Partials 176 176
Continue to review full report at Codecov.
|
songy23
approved these changes
Aug 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #646
Thanks @adriancole for reporting this a while ago.