Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Add started RPC metric for client and server side #1283

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Add started RPC metric for client and server side #1283

merged 2 commits into from
Nov 3, 2022

Conversation

zasweq
Copy link
Contributor

@zasweq zasweq commented Oct 31, 2022

No description provided.

@zasweq zasweq requested review from a team and rghetia as code owners October 31, 2022 22:12
dashpole
dashpole reviewed Nov 1, 2022
View reviewed changes
plugin/ocgrpc/server_metrics.go Outdated Show resolved Hide resolved
plugin/ocgrpc/client_metrics.go Outdated Show resolved Hide resolved
dashpole
dashpole reviewed Nov 1, 2022
View reviewed changes
plugin/ocgrpc/client_metrics.go Outdated Show resolved Hide resolved
plugin/ocgrpc/client_metrics.go Outdated Show resolved Hide resolved
plugin/ocgrpc/server_metrics.go Outdated Show resolved Hide resolved
plugin/ocgrpc/server_metrics.go Outdated Show resolved Hide resolved
zasweq
zasweq commented Nov 1, 2022
View reviewed changes
Copy link
Contributor Author

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the passes.

plugin/ocgrpc/server_metrics.go Outdated Show resolved Hide resolved
plugin/ocgrpc/client_metrics.go Outdated Show resolved Hide resolved
plugin/ocgrpc/client_metrics.go Outdated Show resolved Hide resolved
plugin/ocgrpc/client_metrics.go Outdated Show resolved Hide resolved
plugin/ocgrpc/server_metrics.go Outdated Show resolved Hide resolved
plugin/ocgrpc/server_metrics.go Outdated Show resolved Hide resolved
dashpole
dashpole reviewed Nov 1, 2022
View reviewed changes
plugin/ocgrpc/client_metrics.go Outdated Show resolved Hide resolved
plugin/ocgrpc/client_metrics.go Outdated Show resolved Hide resolved
@dashpole
Copy link
Collaborator

dashpole commented Nov 1, 2022

/bin/sh: 1: goimports: not found

Seems like CI is broken

@dashpole dashpole mentioned this pull request Nov 1, 2022
Merged
@dashpole
Copy link
Collaborator

dashpole commented Nov 2, 2022

This will need to be rebased on #1284 after it merges.

@zasweq
Copy link
Contributor Author

zasweq commented Nov 2, 2022

Yeah, will do once it's merged. Thanks.

@dashpole
Copy link
Collaborator

dashpole commented Nov 3, 2022

test fix PR is merged. Feel free to rebase

@zasweq zasweq force-pushed the started-rpcs-metric branch from ff9f86f to f61cf8f Compare November 3, 2022 19:50
@zasweq
Copy link
Contributor Author

zasweq commented Nov 3, 2022 •
edited
Loading

Done. Thanks.

@dashpole
Copy link
Collaborator

dashpole commented Nov 3, 2022 

goimports FAILED => goimports the following files:
make: *** [Makefile:49: imports] Error 1

./plugin/ocgrpc/client_metrics.go
./plugin/ocgrpc/end_to_end_test.go
./plugin/ocgrpc/server_metrics.go

@dashpole
Copy link
Collaborator

dashpole commented Nov 3, 2022

I think you might need a go fmt ./...

@dashpole dashpole merged commit b1a01ee into census-instrumentation:master Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dashpole dashpole dashpole approved these changes

@rghetia rghetia Awaiting requested review from rghetia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zasweq @dashpole