Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anvil integration #10875

Merged
merged 87 commits into from
May 10, 2024
Merged

Anvil integration #10875

merged 87 commits into from
May 10, 2024

Conversation

martinvol
Copy link
Contributor

@martinvol martinvol commented Jan 10, 2024

This should be merged as soon as possible.

Known issues:

  • StableTokens are deployed but not all exchanges are deployed, only one exchange (Mento) is deployed
  • pretify pre-commit hook breaks when comiting Solidity
  • Not all precompiles implemented, need to create loop to deploy them
  • validators test still doesn't work
  • tests are failing
  • script is still not split (run migrations, run with integration tests, etc)
  • Initialization interfaces need to be defined
  • json doesn't support full config (for example, sender keys are not configurable)
  • validator deployment is oversimplied (din't think it was worth migrating the whole thing)
  • Create a central list of core contracts in solidity
  • Supply of eth not doesn't match what the Celo smart contract thinks it is.
  • Standalone CI job to generate migrations not created.
  • There's a problem with compile times. Libraries are deployed, then contracts recompiled for linking BUT forge for some reason recompiles everything, and takes time.
  • Consider breaking migrations.s.sol into multiple files

Copy link

gitguardian bot commented Mar 12, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9975551 Triggered Generic High Entropy Secret 5ae0e58 packages/protocol/.env.json View secret
9975551 Triggered Generic High Entropy Secret 997b98a packages/protocol/.env.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

openzeppelin-code bot commented Apr 5, 2024

Anvil integration

Generated at commit: 615c785b83587d43ba38a7624f7e00531eef0fd2

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
3
0
15
42
62
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link

socket-security bot commented May 9, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@solidity-parser/parser@0.17.0 unsafe 0 9.57 MB fvictorio
npm/prettier-plugin-solidity@1.3.1 None 0 2.02 MB janther
npm/solidity-comments-extractor@0.0.8 None 0 9.93 kB fvictorio

🚮 Removed packages: npm/prettier-plugin-solidity@1.0.0-alpha.35

View full report↗︎

@pahor167 pahor167 enabled auto-merge (squash) May 10, 2024 11:26
@pahor167 pahor167 merged commit a607b2f into master May 10, 2024
24 checks passed
@pahor167 pahor167 deleted the martinvol/Anvil branch May 10, 2024 13:29
@arthurgousset
Copy link
Contributor

(for visibility) @soloseng moved the todo list into a separate issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants