Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable delegation for validators and their signers #151

Merged

Conversation

shazarre
Copy link
Contributor

This PR disables option to delegate when connected account is either validator or a group (or a vote signer for any of the two). Otherwise allowing to call the contract anyway was resulting in an error and bad experience.

Now - if delegation is not possible - the delegation button will be disabled and the user will be informed about this.

Fixes #110

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
celo-mondo ✅ Ready (Inspect) Visit Preview Jan 23, 2025 1:53pm

@shazarre shazarre changed the title Shazarre/disable delegation for validators and signers 2 Disable delegation for validators and their signers Jan 22, 2025
Copy link

socket-security bot commented Jan 22, 2025

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ampproject/remapping@2.3.0 None 0 78.9 kB jridgewell
npm/@babel/compat-data@7.26.5 None 0 66.4 kB nicolo-ribaudo
npm/@babel/core@7.26.0 environment, filesystem, unsafe 0 794 kB nicolo-ribaudo
npm/@babel/generator@7.26.5 None 0 551 kB nicolo-ribaudo
npm/@babel/helper-compilation-targets@7.26.5 environment +2 84.2 kB nicolo-ribaudo
npm/@babel/helper-module-imports@7.25.9 None 0 63.7 kB nicolo-ribaudo
npm/@babel/helper-module-transforms@7.26.0 None 0 161 kB nicolo-ribaudo
npm/@babel/helper-plugin-utils@7.26.5 None 0 12 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/helper-string-parser@7.25.9 None 0 31.8 kB nicolo-ribaudo
npm/@babel/helper-validator-option@7.25.9 None 0 11.8 kB nicolo-ribaudo
npm/@babel/helpers@7.26.0 None 0 863 kB nicolo-ribaudo
npm/@babel/parser@7.26.5 None 0 1.91 MB nicolo-ribaudo
npm/@babel/plugin-transform-react-jsx-self@7.25.9 None 0 9.02 kB nicolo-ribaudo
npm/@babel/plugin-transform-react-jsx-source@7.25.9 None 0 9.19 kB nicolo-ribaudo
npm/@babel/template@7.25.9 Transitive: environment +1 2.63 MB nicolo-ribaudo
npm/@babel/traverse@7.26.5 None 0 673 kB nicolo-ribaudo
npm/@jridgewell/gen-mapping@0.3.8 🔁 npm/@jridgewell/gen-mapping@0.3.3 None 0 81.6 kB jridgewell
npm/@jridgewell/set-array@1.2.1 🔁 npm/@jridgewell/set-array@1.1.2 None 0 17.9 kB jridgewell
npm/@jridgewell/trace-mapping@0.3.25 🔁 npm/@jridgewell/trace-mapping@0.3.20 None +1 215 kB jridgewell
npm/@types/babel__core@7.20.5 None 0 33 kB types
npm/@types/babel__generator@7.6.8 None 0 11.4 kB types
npm/@types/babel__template@7.4.4 None 0 6.41 kB types
npm/@types/babel__traverse@7.20.6 None 0 84.1 kB types
npm/@vitejs/plugin-react@4.3.4 None 0 38.3 kB vitebot
npm/browserslist@4.24.4 🔁 npm/browserslist@4.24.0 None +1 2.22 MB ai
npm/convert-source-map@2.0.0 None 0 15.9 kB phated
npm/electron-to-chromium@1.5.86 🔁 npm/electron-to-chromium@1.5.36 None 0 155 kB kilianvalkhof
npm/gensync@1.0.0-beta.2 None 0 28.9 kB loganfsmyth
npm/globals@11.12.0 None 0 39.8 kB sindresorhus
npm/jsesc@3.1.0 None 0 32.3 kB mathias
npm/node-releases@2.0.19 🔁 npm/node-releases@2.0.18 None 0 37.2 kB chicoxyzzy
npm/react-refresh@0.14.2 environment 0 58.7 kB react-bot
npm/update-browserslist-db@1.1.2 🔁 npm/update-browserslist-db@1.1.1 None +1 27.1 kB ai

View full report↗︎

aaronmgdr
aaronmgdr previously approved these changes Jan 22, 2025
@aaronmgdr aaronmgdr self-requested a review January 22, 2025 15:47
@shazarre shazarre marked this pull request as ready for review January 23, 2025 10:14
@shazarre shazarre requested a review from a team as a code owner January 23, 2025 10:14
@shazarre shazarre merged commit 2ba5d08 into main Jan 23, 2025
9 checks passed
@shazarre shazarre deleted the shazarre/Disable_delegation_for_validators_and_signers_2 branch January 23, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing to delegate
2 participants