-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable delegation for validators and their signers #151
Merged
shazarre
merged 6 commits into
main
from
shazarre/Disable_delegation_for_validators_and_signers_2
Jan 23, 2025
Merged
Disable delegation for validators and their signers #151
shazarre
merged 6 commits into
main
from
shazarre/Disable_delegation_for_validators_and_signers_2
Jan 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shazarre
changed the title
Shazarre/disable delegation for validators and signers 2
Disable delegation for validators and their signers
Jan 22, 2025
aaronmgdr
previously approved these changes
Jan 22, 2025
aaronmgdr
approved these changes
Jan 23, 2025
shazarre
deleted the
shazarre/Disable_delegation_for_validators_and_signers_2
branch
January 23, 2025 15:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables option to delegate when connected account is either validator or a group (or a vote signer for any of the two). Otherwise allowing to call the contract anyway was resulting in an error and bad experience.
Now - if delegation is not possible - the delegation button will be disabled and the user will be informed about this.
Fixes #110