Add iOS build with bls #528
Conversation
… yet compatible with apple's bitcode
This config works for both iOS and Android
| else | ||
| rustup target add aarch64-apple-ios armv7-apple-ios x86_64-apple-ios i386-apple-ios | ||
| cd vendor/github.com/celo-org/bls-zexe/bls && cargo lipo --release --targets=aarch64-apple-ios,armv7-apple-ios,x86_64-apple-ios,i386-apple-ios | ||
| endif |
There was a problem hiding this comment.
Isn't there an endif missing here?
There was a problem hiding this comment.
Good question 👍 this syntax works but someone mentions it's failing with GNU Make 3.80:
https://stackoverflow.com/a/12297193/158525
My machine has GNU Make 3.81 which was first released in 2006.
I think we're safe, but let me know if you still wanna change it.
There was a problem hiding this comment.
Ah I just changed the structure anyway so no questions about this anymore :D
| @@ -942,6 +942,8 @@ func doXCodeFramework(cmdline []string) { | |||
|
|
|||
| // Build the iOS XCode framework | |||
| build.MustRun(goTool("get", "golang.org/x/mobile/cmd/gomobile", "golang.org/x/mobile/cmd/gobind")) | |||
| // Patch gomobile to disable bitcode for now (rust generated bls lib output is not compatible) | |||
| build.MustRunCommand("sed", "-i", "", `/^[[:space:]]*cflags += \" -fembed-bitcode\"$/s/^/\/\//`, filepath.Join(build.GOPATH(), "src/golang.org/x/mobile/cmd/gomobile/env.go")) | |||
There was a problem hiding this comment.
Too bad it doesn't work :(
Can you try with Rust 1.37? I'm upgrading the build toolchain to that anyway. Seems like people succeeded with recent nightlies, so it might work there: rust-lang/rust#35968 (comment)
There was a problem hiding this comment.
I tried with Rust 1.38 stable and 1.40.0-nightly (2748a9fd9 2019-10-08).
Both failed to link with gomobile when bitcode was enabled (Xcode 10.3). Though the generated rust lib do contain bitcode markers.
Makefile
Outdated
| ifeq ("$(RUSTUP_exists)","") | ||
| $(error "No rustup in PATH, consult https://github.com/celo-org/celo-monorepo/blob/master/SETUP.md") | ||
| else ifeq ("$(CARGO_LIPO_exists)","") | ||
| $(error "No cargo lipo in PATH, run cargo install cargo-lipo") |
There was a problem hiding this comment.
How about installing cargo-lipo for the user here?
There was a problem hiding this comment.
Good idea! I'll do that.
|
Do you need reviews from all five of us? |
This is to fix problems when yarn/npm is run after pod install and clears what has been done by the podspec prepare command.
Description
This PR adds iOS build support with bls.
make iosgenerates the static framework and bls lib that can be used on iOS (device and simulator).The
CeloBlockchainpodspec is to be used by final iOS clients. It's directly compatible with Podfile usinguse_frameworks!. In that case it creates a dynamic framework linking against both geth and bls.I had to disable bitcode for now since the rust generated lib isn't yet compatible with apple's bitcode. See rust-lang/rust#35968 (I tried the latest rust nigthly but I couldn't make it work).
It also exposes the
IPCPathconfig for the node so that iOS can use a relative path to workaround the 104 chars path limit for unix domain sockets.Big thank to @cmcewen who did the initial working prototype!
Tested
Tested that it builds and runs correctly on both iOS and Android.
Other changes
ndk_bundledir used by the MakefileRelated issues
Backwards compatibility
Yes.