[chore] Remove deprecated linters #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linters varcheck and deadcode were deprecated since v1.49.0 because the owners have abandoned them. Both are replaced with unused, see details here golangci/golangci-lint#1841
|
Coverage from tests in coverage: 50.0% of statements across all listed packagescoverage: 63.1% of statements in consensus/istanbul coverage: 40.1% of statements in consensus/istanbul/announce coverage: 54.6% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 65.3% of statements in consensus/istanbul/core coverage: 45.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.4% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
|
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2039 +/- ##
=======================================
Coverage 54.24% 54.25%
=======================================
Files 692 692
Lines 115618 115625 +7
=======================================
+ Hits 62714 62727 +13
- Misses 49056 49057 +1
+ Partials 3848 3841 -7
... and 26 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
palango
approved these changes
Mar 14, 2023
|
Any reason why this is not marked as ready and merged? It looks fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linters
varcheckanddeadcodewere deprecated since v1.49.0 because the owners have abandoned them. Both are replaced withunused, see details here golangci/golangci-lint#1841Other changes
Changed parameters of the codecov report upload, so it always uploads it even when tests failed.