Update to go 1.16 #1454
Merged
Update to go 1.16 #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #21934 in upstream geth.
conflict with module rename that was fixed
This is due to a change in golang 1.16 which panics when using a non-unique hash in a HMAC. This change copies the upstream change which uses a new sha instance rather than the existing hash value. Discv5 is next touched in: ethereum/go-ethereum#21647 where it is reworked. Full history of the encoding test: git log geth/master --full-history -- p2p/discover/v5_encoding_test.go
|
CI shows the ios build failing |
Looking into it atm. Looks like there was some update in go 1.16 that's messing with go.mod/go.sum files in a weird way. |
|
I think I've tracked it down to the fact that our version of go mobile is out of date with master and their upstream does create a go.sum file. If that doesn't resolve this there's another golang issue that looks similar that looks like it will be released with 1.16.3 |
trianglesphere
pushed a commit
that referenced
this pull request
Mar 25, 2021
* go.mod: update github.com/golang/snappy See #21934 in upstream geth. * accounts/abi/bind: fix up Go mod files for Go 1.16 conflict with module rename that was fixed * Dockerfile: bump to Go 1.16 base images * travis, appveyor, checksums: bump Go to 1.16 See ethereum/go-ethereum@c5023e1 * Update builders to go1.16 * Fix panic with discv5 This is due to a change in golang 1.16 which panics when using a non-unique hash in a HMAC. This change copies the upstream change which uses a new sha instance rather than the existing hash value. Discv5 is next touched in: ethereum/go-ethereum#21647 where it is reworked. Full history of the encoding test: git log geth/master --full-history -- p2p/discover/v5_encoding_test.go * Update go mobile * Update libs patch for android build Co-authored-by: Péter Szilágyi <peterke@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates go-celo to golang 1.16.
Changes
golang.com/x/mobileto fix an issue withmake iosTested
Unit tests & CI
Related issues