New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve initialization #37

Merged

kevinyamauchi merged 2 commits into cellcanvas:main from kevinyamauchi:improve-initialization

Apr 4, 2024

Contributor

kevinyamauchi commented Apr 4, 2024

As discussed in #35 , this PR fixes the initialization behavior of the widgets:

initializes the surface layer with shading set to none
fixes the re-enabling of the picking layer after a layer has been deleted. the new behavior is that when one of the annotation layers associated with the picking (e.g., points or vectors) is deleted from the viewer, the picking mode is disabled. the user can then re-enable the picking and the layers are re-created.

kevinyamauchi added 2 commits

April 4, 2024 14:20


          handle case when layer removed

fab005b


          allow picking layers to be re-enabled

e1f80a7

kevinyamauchi mentioned this pull request

Potential usability improvements #35

Open

8 tasks

kevinyamauchi merged commit d6b2ac1 into cellcanvas:main

9 checks passed

kevinyamauchi deleted the improve-initialization branch

April 4, 2024 14:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet