-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Author fields on annotaion; BICAN ext no additional props #109
Conversation
general_schema.json
Outdated
@@ -128,6 +128,10 @@ | |||
"items": { | |||
"type": "string", | |||
"description": "List of synonyms" | |||
}, | |||
"author_annotation_fields": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems nesting is wrong, this element is inside synonyms
.
Also, Should this be an array of objects? Such as:
"author_annotation_fields": {
"type": "array",
"description": "A set of author defined key value pairs annotating the cell set. The names and aims of these fields MUST not clash with annotationThis schema accepts author defined fields.",
"items": {
"type": "object",
"description": "Author defined key value pairs annotating the cell set. The names and aims of these fields MUST not clash with annotationThis schema accepts author defined fields."
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly shouldn't be in synonym!
I think it should be an object (dictionary) rather than a list.
Validation Passes. |
Seems the example data Yao_ABC_labelset.json wasn't in synch with the schema, updated it accordingly. |
#rollschema |
Rolled schema files: schemas.zip BICAN schema documentationGeneral Cell Annotation Open StandardA general, open-standard schema for cell annotations which records connections, types, provenance and evidence. Properties
|
CAP schema documentationGeneral Cell Annotation Open StandardA general, open-standard schema for cell annotations which records connections, types, provenance and evidence. Properties
|
Have updated. |
Validation Passes. |
#rollschema |
Rolled schema files: schemas.zip BICAN schema documentationGeneral Cell Annotation Open StandardA general, open-standard schema for cell annotations which records connections, types, provenance and evidence. Properties
|
CAP schema documentationGeneral Cell Annotation Open StandardA general, open-standard schema for cell annotations which records connections, types, provenance and evidence. Properties
|
Can we merge this PR? We are currently using a non-standard properties to support this and this is making linkml driven operations harder. |
No description provided.