Fix #35 - bool typed params are not passed correctly #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does a simple check that looks for `bool` typed params and converts them to string values in lowercase.
3lixy
suggested changes
Jan 2, 2018
There was a problem hiding this comment.
.iteritems() i believe is python2 only http://python-future.org/compatible_idioms.html. I think this repo is py3 compatible.
if you expect a value to be bool then i would use
if value is True
Would you be able to add any unit tests?
- iteritems() is only py2 compatible, changing to items(), although inefficient, should be fine for this and does not require importing future - Add a verbose check to ensure bool type param is True
|
Should be py3 compatible now, and added |
|
I tested the code and it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a simple check that looks for
booltyped params and converts them to string values in lowercase.