Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: stop using deprecated math/rand.Read #222

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jul 5, 2023

Closes #221

@rootulp rootulp requested review from staheri14 and evan-forbes July 5, 2023 17:06
@rootulp rootulp self-assigned this Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #222 (c2df049) into master (9c342ae) will increase coverage by 0.82%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   77.43%   78.26%   +0.82%     
==========================================
  Files           7        7              
  Lines         523      529       +6     
==========================================
+ Hits          405      414       +9     
  Misses         69       69              
+ Partials       49       46       -3     
Impacted Files Coverage Δ
extendeddatacrossword.go 69.65% <0.00%> (+2.47%) ⬆️

@rootulp rootulp enabled auto-merge (squash) July 5, 2023 17:11
@rootulp rootulp changed the title fix: stop using math/rand.Read chore: stop using deprecated math/rand.Read Jul 5, 2023
@rootulp rootulp merged commit 2ad653d into celestiaorg:main Jul 5, 2023
rootulp added a commit that referenced this pull request Jul 6, 2023
Closes #160
Closes #223
Blocked on #222

## Screenshot

<img width="854" alt="Screenshot 2023-07-05 at 5 27 03 PM"
src="https://github.com/celestiaorg/rsmt2d/assets/3699047/c7a4a6d8-c6a1-473e-985a-28a49bdf5ffc">

Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
@rootulp rootulp deleted the rp/fix-rand-read branch July 6, 2023 13:28
0xchainlover pushed a commit to celestia-org/rsmt2d that referenced this pull request Aug 1, 2024
Closes celestiaorg/rsmt2d#160
Closes celestiaorg/rsmt2d#223
Blocked on celestiaorg/rsmt2d#222

## Screenshot

<img width="854" alt="Screenshot 2023-07-05 at 5 27 03 PM"
src="https://github.com/celestiaorg/rsmt2d/assets/3699047/c7a4a6d8-c6a1-473e-985a-28a49bdf5ffc">

Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rand.Read has been deprecated since Go 1.20
3 participants