deps: bump hashicorp/golang-lru to v2 and move from ARC to 2Q cache #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
requested review from
tzdybal,
renaynay,
Wondertan,
vgonkivs and
gupadhyaya
as code owners
|
Thank you for bump and explanation @cristaloleg :) no benchmarks necessary if they didn't provide them either. |
|
As discussed in sync, we should migrate to 2Q(or smlr) to avoid potential issues with ARC being patented by IBM |
cristaloleg
changed the title
walldiss
approved these changes
May 22, 2024
Wondertan
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the major version of
github.com/hashicorp/golang-lrufromv1tov2. The biggest improvement is support for generics. So, we can experience a bit better performance due to fewer allocations thanv1(where every value was wrapped ininterface{}, which causes allocation in most cases).I'm not sure if I should prove my words with benchmarks 'cause the
golang-lruauthors didn't post any benchmarks.Also here: moving from ARC cache to 2Q (two queue) to avoid potential issues with ARC patent.