chore(deps): upgrade to cosmos-ledger-go v0.14.0 #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
requested review from
cmwaters,
rach-id and
ninabarbakadze
and removed request for
a team and
rach-id
cmwaters
approved these changes
Dec 20, 2024
|
Yep, Go API breaking b/c of cosmos/ledger-cosmos-go#39 |
ninabarbakadze
approved these changes
Dec 20, 2024
|
I was just double checking that nothing breaks for the ledger uses themselves |
rootulp
merged commit d2163ce
into
celestiaorg:release/v0.46.x-celestia
35 of 36 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #423
The diff in this PR was sourced from #349 when we previously upgraded to ledger-cosmos-go v0.13.x and handled the breaking change. We subsequently reverted that change in this PR to keep the diff in this repo small because ledger-cosmos-go backported the patch to v0.12.4 which didn't contain the breaking change.
Now we need to upgrade through the breaking change (again) b/c the patch for the Ledger Nano S+ fix was only released in v0.14.0. 😅
Testing
I verified that a celestia-app binary built using this version of cosmos-sdk can still sign txs (with a Ledger Nano X).