feat: allow endblocker to update app version #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
approved these changes
May 19, 2023
| @@ -465,6 +465,8 @@ func (app *BaseApp) GetConsensusParams(ctx sdk.Context) *abci.ConsensusParams { | |||
| cp.Validator = &vp | |||
| } | |||
|
|
|||
| cp.Version = &tmproto.VersionParams{AppVersion: app.appVersion} | |||
There was a problem hiding this comment.
nice, so now we should just be able to call app.SetVersion instead of wrapping endblock, I can dig it
|
we should try to upstream this (later) |
|
I need to dig in to how the SDK do it now because they've made some heavy modifications in that area since v0.46 |
Codecov Report
@@ Coverage Diff @@
## release/v0.46.x-celestia #321 +/- ##
=========================================================
Coverage 65.54% 65.55%
=========================================================
Files 666 666
Lines 70983 71018 +35
=========================================================
+ Hits 46529 46553 +24
- Misses 21876 21882 +6
- Partials 2578 2583 +5
|
|
Ref: cosmos#16243 |
|
It looks like v0.47 onwards will support altering the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, I see know what that an application can use the end blocker to change the app version. All app version changes happen during a coordinated restart which means only the Info abci call is used to update the app version. This change means that the consensus param returned in EndBlock is always the applications app version. This means a module need only use SetProtocolVersion to enact a app version change in the following block