Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add retry logic for the grpc subscription #4093

Merged
merged 11 commits into from
Feb 13, 2025
Merged

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Feb 6, 2025

Closes #4090
Added retry logic for the grpc subscription. In case, the server goes down for some reason, block fetcher will attempt to create a new subscription every 5 seconds.

Screenshot 2025-02-11 at 12 57 42

Screenshot shows that re-subscriptions happens once we receive EOF error

@vgonkivs vgonkivs added the kind:fix Attached to bug-fixing PRs label Feb 6, 2025
@vgonkivs vgonkivs self-assigned this Feb 6, 2025
@vgonkivs vgonkivs marked this pull request as draft February 7, 2025 15:56
@vgonkivs vgonkivs marked this pull request as ready for review February 11, 2025 11:32
Copy link
Member

@walldiss walldiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less code, more tests - love it! Much simpler and easier than it used to be!

Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack - thank you for cleanup!

@vgonkivs vgonkivs merged commit 70d6351 into main Feb 13, 2025
29 of 31 checks passed
@vgonkivs vgonkivs deleted the fix_grpc_retry branch February 13, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridge Node Stuck After Archive RPC Restart
5 participants