-
Notifications
You must be signed in to change notification settings - Fork 974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): add retry logic for the grpc subscription #4093
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
reviewed
Feb 6, 2025
cristaloleg
reviewed
Feb 6, 2025
cristaloleg
reviewed
Feb 6, 2025
cristaloleg
reviewed
Feb 6, 2025
walldiss
reviewed
Feb 6, 2025
renaynay
reviewed
Feb 7, 2025
renaynay
reviewed
Feb 7, 2025
a96e1b1
to
6aabca3
Compare
renaynay
reviewed
Feb 11, 2025
Wondertan
reviewed
Feb 11, 2025
walldiss
reviewed
Feb 11, 2025
walldiss
reviewed
Feb 11, 2025
7fee31b
to
0f3aea6
Compare
walldiss
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
less code, more tests - love it! Much simpler and easier than it used to be!
cristaloleg
approved these changes
Feb 13, 2025
renaynay
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utack - thank you for cleanup!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4090
Added retry logic for the grpc subscription. In case, the server goes down for some reason, block fetcher will attempt to create a new subscription every 5 seconds.
Screenshot shows that re-subscriptions happens once we receive EOF error