feat(metrics): send bitswap metric to prometheus #3701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
added
kind:feat
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
cristaloleg
as code owners
Wondertan
reviewed
Aug 29, 2024
walldiss
force-pushed
the
enable-bitswap-metrics
branch
from
a71f262
to
c146cfe
Compare
walldiss
force-pushed
the
enable-bitswap-metrics
branch
from
c146cfe
to
91cd811
Compare
Wondertan
previously approved these changes
Aug 29, 2024
cristaloleg
reviewed
Aug 30, 2024
cristaloleg
previously approved these changes
Aug 30, 2024
cristaloleg
approved these changes
Aug 30, 2024
Wondertan
approved these changes
Aug 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3701 +/- ##
==========================================
+ Coverage 44.83% 45.65% +0.82%
==========================================
Files 265 281 +16
Lines 14620 16025 +1405
==========================================
+ Hits 6555 7317 +762
- Misses 7313 7869 +556
- Partials 752 839 +87 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable exporting bitswap metrics to prometheus