Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add lint imports ci action #3677

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

walldiss
Copy link
Member

@walldiss walldiss commented Aug 22, 2024

Adds lint imports check to CI to ensure imports order is correct. Found by failed lint locally, that was green in ci.

@walldiss walldiss self-assigned this Aug 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.63%. Comparing base (2469e7a) to head (16173cb).
Report is 175 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3677      +/-   ##
==========================================
+ Coverage   44.83%   45.63%   +0.80%     
==========================================
  Files         265      281      +16     
  Lines       14620    16044    +1424     
==========================================
+ Hits         6555     7322     +767     
- Misses       7313     7882     +569     
- Partials      752      840      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@walldiss walldiss merged commit 87e2802 into celestiaorg:main Aug 23, 2024
27 of 30 checks passed
@walldiss walldiss deleted the ci-sort-imports branch August 23, 2024 09:20
ninabarbakadze pushed a commit to ninabarbakadze/celestia-node that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants