feat(blob): implement length method #3606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
requested review from
renaynay,
Wondertan,
distractedm1nd,
walldiss,
ramin and
cristaloleg
as code owners
Wondertan
reviewed
Jul 30, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3606 +/- ##
==========================================
+ Coverage 44.83% 45.42% +0.59%
==========================================
Files 265 280 +15
Lines 14620 15867 +1247
==========================================
+ Hits 6555 7208 +653
- Misses 7313 7826 +513
- Partials 752 833 +81 ☔ View full report in Codecov by Sentry. |
Wondertan
approved these changes
Jul 30, 2024
renaynay
approved these changes
Jul 31, 2024
sebasti810
pushed a commit
to sebasti810/celestia-node
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
Length()method to the Blob struct that helps to determine the number of the shares in the blob.