Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nodebuilder/p2p): LNs restricted to acting as DHT clients *only* #3590

Merged
merged 1 commit into from
Jul 24, 2024
Merged

fix(nodebuilder/p2p): LNs restricted to acting as DHT clients *only* #3590

merged 1 commit into from
Jul 24, 2024

Conversation

renaynay
Copy link
Member

Resolves #3574

Potentially targets #3573

@renaynay renaynay added area:p2p kind:fix Attached to bug-fixing PRs labels Jul 24, 2024
@renaynay renaynay self-assigned this Jul 24, 2024
cristaloleg
cristaloleg approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.60%. Comparing base (2469e7a) to head (d0a48cf).
Report is 146 commits behind head on main.

Files Patch % Lines
nodebuilder/p2p/routing.go 75.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3590      +/-   ##
==========================================
+ Coverage   44.83%   45.60%   +0.77%     
==========================================
  Files         265      280      +15     
  Lines       14620    15854    +1234     
==========================================
+ Hits         6555     7231     +676     
- Misses       7313     7796     +483     
- Partials      752      827      +75

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wondertan Wondertan merged commit 4b2f507 into celestiaorg:main Jul 24, 2024
25 of 29 checks passed
@Wondertan Wondertan deleted the dht-client-ln branch July 24, 2024 10:41
Wondertan pushed a commit that referenced this pull request Jul 24, 2024
@renaynay @Wondertan
fix(nodebuilder/p2p): LNs restricted to acting as DHT clients *only* (#…
6549873 
…3590)

Resolves #3574

Potentially targets #3573
sebasti810 pushed a commit to sebasti810/celestia-node that referenced this pull request Aug 14, 2024
@renaynay @sebasti810
fix(nodebuilder/p2p): LNs restricted to acting as DHT clients *only* (c…
c1b6d74 
…elestiaorg#3590)

Resolves celestiaorg#3574

Potentially targets celestiaorg#3573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramin ramin ramin approved these changes

@cristaloleg cristaloleg cristaloleg approved these changes

@Wondertan Wondertan Wondertan approved these changes

@vgonkivs vgonkivs vgonkivs approved these changes

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd distractedm1nd is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

Assignees

@renaynay renaynay

Labels
area:p2p kind:fix Attached to bug-fixing PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(p2p/dht): disable dht server on Light node
6 participants
@renaynay @codecov-commenter @ramin @cristaloleg @Wondertan @vgonkivs