Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(swamp): remove always failing assert #3463

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Conversation

cristaloleg
Copy link
Contributor

From context.Context.Err() error documentation (https://pkg.go.dev/context#Context):

	// If Done is not yet closed, Err returns nil.
	// If Done is closed, Err returns a non-nil error explaining why:
	// Canceled if the context was canceled
	// or DeadlineExceeded if the context's deadline passed.
	// After Err returns a non-nil error, successive calls to Err return the same error.
	Err() error

In other words when we observe a cancelled context Err is always not nil https://go.dev/play/p/2N6F75a70lK

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow

@renaynay renaynay enabled auto-merge (squash) June 6, 2024 13:12
@cristaloleg cristaloleg changed the title chore(swamp): remove always failing assert Draft: chore(swamp): remove always failing assert Jun 6, 2024
@cristaloleg cristaloleg marked this pull request as draft June 6, 2024 13:16
auto-merge was automatically disabled June 6, 2024 13:16

Pull request was converted to draft

@cristaloleg cristaloleg changed the title Draft: chore(swamp): remove always failing assert chore(swamp): remove always failing assert Jun 6, 2024
@renaynay renaynay marked this pull request as ready for review June 6, 2024 13:23
@renaynay renaynay enabled auto-merge (squash) June 6, 2024 13:23
@renaynay renaynay merged commit 8254438 into main Jun 6, 2024
26 of 27 checks passed
@renaynay renaynay deleted the swamp/drop-require-ctx branch June 6, 2024 13:29
@cristaloleg cristaloleg self-assigned this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants