Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve godoc for the blob service #3422

Merged
merged 3 commits into from
May 24, 2024

Conversation

vgonkivs
Copy link
Member

Self-explanatory

@vgonkivs vgonkivs added kind:docs For solely documentation PRs area:blob labels May 22, 2024
@vgonkivs vgonkivs self-assigned this May 22, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.74%. Comparing base (2469e7a) to head (428e503).
Report is 74 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3422      +/-   ##
==========================================
- Coverage   44.83%   44.74%   -0.10%     
==========================================
  Files         265      272       +7     
  Lines       14620    15282     +662     
==========================================
+ Hits         6555     6838     +283     
- Misses       7313     7657     +344     
- Partials      752      787      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Wondertan
Wondertan previously approved these changes May 23, 2024
ramin
ramin previously approved these changes May 23, 2024
blob/service.go Outdated Show resolved Hide resolved
blob/service.go Outdated Show resolved Hide resolved
blob/blob.go Outdated Show resolved Hide resolved
blob/parser.go Outdated Show resolved Hide resolved
@ramin
Copy link
Contributor

ramin commented May 23, 2024

@vgonkivs made a few minor grammar suggestions but fine as is anyway

Co-authored-by: ramin <raminkeene@gmail.com>
@vgonkivs vgonkivs dismissed stale reviews from ramin and Wondertan via a2e458d May 23, 2024 13:54
@vgonkivs vgonkivs requested review from ramin and Wondertan May 23, 2024 13:56
@ramin ramin enabled auto-merge (squash) May 24, 2024 10:46
@ramin ramin requested a review from cristaloleg as a code owner May 24, 2024 10:46
@ramin ramin merged commit 20c2beb into celestiaorg:main May 24, 2024
24 of 25 checks passed
ramin added a commit that referenced this pull request Jun 6, 2024
Self-explanatory
<!--
Thank you for submitting a pull request!

Please make sure you have reviewed our contributors guide before
submitting your
first PR.

Please ensure you've addressed or included references to any related
issues.

Tips:
- Use keywords like "closes" or "fixes" followed by an issue number to
automatically close related issues when the PR is merged (e.g., "closes
#123" or "fixes #123").
- Describe the changes made in the PR.
- Ensure the PR has one of the required tags (kind:fix, kind:misc,
kind:break!, kind:refactor, kind:feat, kind:deps, kind:docs, kind:ci,
kind:chore, kind:testing)

-->

---------

Co-authored-by: ramin <raminkeene@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:blob kind:docs For solely documentation PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants