-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(share/eds): Store nmt nodes on failed reconstruction #3305
feat(share/eds): Store nmt nodes on failed reconstruction #3305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct. I feel like this needs a test, which will stay for after shwap times.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3305 +/- ##
==========================================
+ Coverage 44.83% 45.20% +0.36%
==========================================
Files 265 272 +7
Lines 14620 14942 +322
==========================================
+ Hits 6555 6754 +199
- Misses 7313 7430 +117
- Partials 752 758 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with hlib that this needs a test case -- I think we should make an issue or document some test cases somewhere that we need to implement.
|
…struction (#3306) We should not restrict the BEFP constructor to collect proof only for orthogonal axes to ErrByzantine. This PR enables the constructor to attempt building both Row and Col proofs, irrespective of the ErrByzantine axis type. Additionally, it prevents the BEFP constructor from requesting proofs pr shars from the network by granting access exclusively to the local blockstore. There should be sufficient proofs and shares in the local blockstore at the time BEFP is detected. Breaks befp message, by introducing proofAxis field, which is not supported by older befp subscribers. Depends on - #3305 to have enough data in blockstore. - celestiaorg/rsmt2d#310 to provide proper coordinates of verified shares
Store repaired shares and calculated nmt proofs if reconstruction failed.