Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(unit tests): YOINK unit tests with race detector temporarily #3147

Merged
merged 3 commits into from
Jan 31, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions .github/workflows/go-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,21 +105,27 @@ jobs:
file: ./coverage.txt
name: coverage-${{ matrix.os }}

unit_test_race:
needs: [lint, go_mod_tidy_check]
name: Unit Tests with Race Detector (ubuntu-latest)
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4

- name: set up go
uses: actions/setup-go@v5
with:
go-version: ${{ inputs.go-version }}

- name: execute test run
run: make test-unit-race ENABLE_VERBOSE=${{ needs.setup.outputs.debug }}
# @ramin - Temporarily removed while we figure out getting
# these unit tests consistently running on ubuntu-latest
# and then enabled for macos-latest. We aren't requiring
# unit_race_test to pass for PRs so lets remove and reintroduce
# once green
#
# unit_test_race:
# needs: [lint, go_mod_tidy_check]
# name: Unit Tests with Race Detector (ubuntu-latest)
# runs-on: ubuntu-latest

# steps:
# - uses: actions/checkout@v4

# - name: set up go
# uses: actions/setup-go@v5
# with:
# go-version: ${{ inputs.go-version }}

# - name: execute test run
# run: make test-unit-race ENABLE_VERBOSE=${{ needs.setup.outputs.debug }}

integration_test:
name: Integration Tests
Expand Down
Loading