fix(tests/befp): fix panic in befp test #3108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
added
kind:testing
vgonkivs
requested review from
renaynay,
Wondertan,
distractedm1nd,
walldiss and
ramin
as code owners
renaynay
reviewed
Jan 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3108 +/- ##
==========================================
+ Coverage 51.08% 51.27% +0.18%
==========================================
Files 177 177
Lines 11157 11157
==========================================
+ Hits 5700 5721 +21
+ Misses 4958 4939 -19
+ Partials 499 497 -2 ☔ View full report in Codecov by Sentry. |
walldiss
approved these changes
Jan 18, 2024
ramin
approved these changes
Jan 19, 2024
renaynay
pushed a commit
that referenced
this pull request
Jan 23, 2024
ShareWithProofs collection happens async and it does not guarantee that Shares at index [1] will be non-nil. Panic happened in `incorrect share with Proof` when `befp.Shares[1] == nil` tested with `go test -v -count=300 -run ^TestBEFP_Validate$ github.com/celestiaorg/celestia-node/share/eds/byzantine`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShareWithProofs collection happens async and it does not guarantee that Shares at index [1] will be non-nil. Panic happened in
incorrect share with Proofwhenbefp.Shares[1] == niltested with
go test -v -count=300 -run ^TestBEFP_Validate$ github.com/celestiaorg/celestia-node/share/eds/byzantine