chore: bump celestia-app to v1.0.0-rc2 #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2305 +/- ##
=======================================
Coverage 50.55% 50.56%
=======================================
Files 154 154
Lines 9733 9736 +3
=======================================
+ Hits 4921 4923 +2
Misses 4385 4385
- Partials 427 428 +1
|
renaynay
previously approved these changes
Jun 2, 2023
vgonkivs
previously approved these changes
Jun 2, 2023
renaynay
previously approved these changes
Jun 2, 2023
|
@evan-forbes, linter seems to complain after the merge, do you mind fixing it? |
auto-merge was automatically disabled
June 5, 2023 18:37
Head branch was pushed to by a user without write access
|
sorry forgot to mention @Wondertan fixed in 46e2a70 also bumped to rc2 since why not |
evan-forbes
changed the title
Wondertan
approved these changes
Jun 6, 2023
distractedm1nd
approved these changes
Jun 6, 2023
walldiss
approved these changes
Jun 6, 2023
walldiss
approved these changes
Jun 6, 2023
walldiss
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
bumps app to latest release candidate. I'm not sure how celestia-node wants to handle app version changes. I'm completely unaware of any existing plans, so aplogies if this is already planned for, but ideally we don't rely on the latest appversion constant. This is definitely fine for v1, but when v2 comes along we will want to change which version we use according to what is in the header.
Checklist