chore(nodebuilder/tests): Clean up sync_test tests #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
requested review from
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2162 +/- ##
==========================================
+ Coverage 50.80% 50.89% +0.08%
==========================================
Files 155 155
Lines 9766 9766
==========================================
+ Hits 4962 4970 +8
+ Misses 4369 4362 -7
+ Partials 435 434 -1 |
distractedm1nd
previously approved these changes
May 29, 2023
Wondertan
reviewed
May 29, 2023
Wondertan
reviewed
Jun 13, 2023
distractedm1nd
previously approved these changes
Jun 14, 2023
… granular understanding of syncing
… in swamp instead of NewNodeWithConfig
renaynay
force-pushed
the
swamp-cleanussy
branch
from
6018e34
to
fe27c9b
Compare
Wondertan
approved these changes
Jun 15, 2023
distractedm1nd
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of the swamp cleanussy effort to clean up our integration tests and make them more deterministic + readable.
This PR focuses on
sync_test.gofile.It also contains a change to fraud proof broadcasting test but I can happily split out into separate PR.