feat(tracer): Add shutdown hook for tracer #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougEfresh
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
dougEfresh
force-pushed
the
trace-shutdown
branch
2 times, most recently
from
1d1e1a1
to
d4efa06
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1524 +/- ##
==========================================
- Coverage 44.83% 44.73% -0.11%
==========================================
Files 265 272 +7
Lines 14620 15238 +618
==========================================
+ Hits 6555 6816 +261
- Misses 7313 7628 +315
- Partials 752 794 +42 ☔ View full report in Codecov by Sentry. |
Wondertan
reviewed
Dec 21, 2022
dougEfresh
force-pushed
the
trace-shutdown
branch
from
d4efa06
to
d00bc4b
Compare
dougEfresh
force-pushed
the
trace-shutdown
branch
from
d00bc4b
to
7d57927
Compare
|
Needs rebase |
|
@dougEfresh do you want to rebase this or should we take over the PR? |
Will rebase soon |
|
hey @dougEfresh do you want to bring this one home? I can take over if not |
renaynay
force-pushed
the
trace-shutdown
branch
from
7d57927
to
8fdde29
Compare
Wondertan
reviewed
Nov 29, 2023
Wondertan
requested changes
May 7, 2024
Wondertan
approved these changes
May 9, 2024
vgonkivs
approved these changes
May 9, 2024
walldiss
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #935
Tracer is not shutdown gracefully and thus traces are lost.
I have added tracer to the FX lifecycle and created a
WithTracingfunction innodebuilder/settings.go