-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(header/p2p): improve logging #1520
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
added
area:header
Extended header
kind:misc
Attached to miscellaneous PRs
labels
Dec 20, 2022
vgonkivs
requested review from
renaynay,
Wondertan and
distractedm1nd
as code owners
December 20, 2022 12:20
Codecov Report
@@ Coverage Diff @@
## main #1520 +/- ##
==========================================
- Coverage 55.44% 55.05% -0.40%
==========================================
Files 204 208 +4
Lines 12147 12757 +610
==========================================
+ Hits 6735 7023 +288
- Misses 4743 5020 +277
- Partials 669 714 +45
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
renaynay
previously approved these changes
Dec 20, 2022
distractedm1nd
previously approved these changes
Dec 20, 2022
Wondertan
requested changes
Dec 20, 2022
vgonkivs
dismissed stale reviews from distractedm1nd and renaynay
via
December 21, 2022 09:30
1d8285e
distractedm1nd
approved these changes
Dec 21, 2022
renaynay
approved these changes
Dec 21, 2022
Wondertan
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Change the logging level in the case when headers are not found in the store.
Checklist