Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(header/p2p): improve logging #1520

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Dec 20, 2022

Overview

Change the logging level in the case when headers are not found in the store.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@vgonkivs vgonkivs added area:header Extended header kind:misc Attached to miscellaneous PRs labels Dec 20, 2022
@vgonkivs vgonkivs self-assigned this Dec 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Merging #1520 (1d8285e) into main (8b71eaf) will decrease coverage by 0.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1520      +/-   ##
==========================================
- Coverage   55.44%   55.05%   -0.40%     
==========================================
  Files         204      208       +4     
  Lines       12147    12757     +610     
==========================================
+ Hits         6735     7023     +288     
- Misses       4743     5020     +277     
- Partials      669      714      +45     
Impacted Files Coverage Δ
header/p2p/server.go 66.93% <100.00%> (+0.81%) ⬆️
nodebuilder/share/module.go 58.73% <0.00%> (-18.36%) ⬇️
share/empty.go 86.66% <0.00%> (-13.34%) ⬇️
nodebuilder/share/constructors.go 92.10% <0.00%> (-7.90%) ⬇️
nodebuilder/p2p/flags.go 65.82% <0.00%> (-1.65%) ⬇️
nodebuilder/p2p/network.go 100.00% <0.00%> (ø)
share/p2p/shrexeds/options.go 40.74% <0.00%> (ø)
share/p2p/shrexeds/client.go 69.41% <0.00%> (ø)
share/p2p/shrexeds/server.go 62.26% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

renaynay
renaynay previously approved these changes Dec 20, 2022
distractedm1nd
distractedm1nd previously approved these changes Dec 20, 2022
header/p2p/server.go Outdated Show resolved Hide resolved
@vgonkivs vgonkivs merged commit 568b166 into celestiaorg:main Dec 21, 2022
@vgonkivs vgonkivs deleted the fix_logging branch January 9, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:header Extended header kind:misc Attached to miscellaneous PRs
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants