feat!: share.Getter and getters.IPLDGetter

[distractedm1nd]

Overview

Closes #1488

• removes service.ShareService
• introduces share.Getter
• implements getters.IPLDGetter
• Full/Light share.Availability implementations now take a share.Getter
• Updates ADR with new interface
• Updates share Module/API defs and mocks

TODO:

• Different directory structure?
• Test changes, looking forward to suggestions + improvements

Checklist

• New and updated code has appropriate documentation
• New and updated code has new and/or updated testing
• Required CI checks are passing
• Linked issues closed with keywords

[Wondertan]

#1488 was updated with the final form of the Getter interface.

We don't have to implement NamespaceShares.Verify here and can live it to #1497/

[codecov-commenter]

Codecov Report

Merging #1518 (af636ed) into main (bbe34a2) will increase coverage by 0.08%.
The diff coverage is 74.59%.

@@            Coverage Diff             @@
##             main    #1518      +/-   ##
==========================================
+ Coverage   55.42%   55.51%   +0.08%     
==========================================
  Files         214      215       +1     
  Lines       13123    13172      +49     
==========================================
+ Hits         7274     7313      +39     
- Misses       5107     5117      +10     
  Partials      742      742              

Impacted Files	Coverage Δ
api/gateway/share.go	0.00% <0.00%> (ø)
nodebuilder/das/mocks/api.go	65.21% <0.00%> (-34.79%)	⬇️
nodebuilder/fraud/mocks/api.go	16.66% <ø> (ø)
nodebuilder/header/mocks/api.go	46.87% <0.00%> (ø)
nodebuilder/share/mocks/api.go	8.16% <0.00%> (ø)
nodebuilder/share/share.go	0.00% <0.00%> (ø)
nodebuilder/state/mocks/api.go	18.32% <ø> (ø)
share/availability/test/testing.go	81.01% <ø> (ø)
share/getter.go	84.09% <84.09%> (ø)
share/getters/ipld.go	86.30% <86.30%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[Wondertan]

Breaking and needs some adiditonal reviewes on comments and error messages, but overall a great work + refactor.

Mostly thoughts and notes, but also a few things needs to be changed, like proof collection seems to be broken.

[Wondertan]

In sync with @distractedm1nd, we decided to:

• Remove caching out of IPLDGetter and future ShrexGetter and make this caching work via a new TeeGetter
• Change GetShares to Getter interface to GetEDS returning full rsmt2d EDS structure
• EDS to implement JSON(Un)Marhaller interfaces to make it compatible with RPC

[Wondertan]

👍🏻