fix(das): Correct WithMetrics fx Invocation
#1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrandz
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1366 +/- ##
==========================================
- Coverage 55.06% 55.03% -0.03%
==========================================
Files 178 178
Lines 10689 10689
==========================================
- Hits 5886 5883 -3
- Misses 4227 4229 +2
- Partials 576 577 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
derrandz
force-pushed
the
metrics-debugging
branch
from
50ba038
to
fc08cb4
Compare
derrandz
changed the title
walldiss
approved these changes
Nov 14, 2022
Wondertan
approved these changes
Nov 15, 2022
renaynay
changed the title
WithMetrics fx Invocation
renaynay
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the
das.WithMetricsfx invokation which enables metrics collection in the DASer module.Impact
Negligeable
Owners
@derrandz