Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(nodebuilder): Logger names in subpackages to constructor/<subpkg> #1324

Merged
merged 2 commits into from
Nov 9, 2022
Merged

refactor(nodebuilder): Logger names in subpackages to constructor/<subpkg> #1324

merged 2 commits into from
Nov 9, 2022

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented Nov 3, 2022

Resolves #1288

@renaynay renaynay added area:node Node kind:misc Attached to miscellaneous PRs labels Nov 3, 2022
@renaynay renaynay self-assigned this Nov 3, 2022
distractedm1nd
distractedm1nd previously approved these changes Nov 4, 2022
View reviewed changes
@Wondertan Wondertan mentioned this pull request Nov 8, 2022
Open
Wondertan
Wondertan requested changes Nov 8, 2022
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logger is for the module, not only the constructor.
modfraud or mod/fraud or module/fraud

Related #1323

Wondertan
Wondertan approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changing this to module!

distractedm1nd
distractedm1nd approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@distractedm1nd distractedm1nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

module/x much better than modX, thanks

@renaynay renaynay merged commit 545aae4 into celestiaorg:main Nov 9, 2022
@renaynay renaynay deleted the logger-rename branch November 9, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@distractedm1nd distractedm1nd distractedm1nd approved these changes

@Wondertan Wondertan Wondertan approved these changes

@vgonkivs vgonkivs vgonkivs approved these changes

Assignees

@renaynay renaynay

Labels
area:node Node kind:misc Attached to miscellaneous PRs
Projects
No open projects
Celestia Node
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(nodebuilder): change log loggers to $MODULENAME/constructor instead of $MODULENAME-module
4 participants
@renaynay @distractedm1nd @Wondertan @vgonkivs