-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump celestia app v0.9.0 #1300
chore: bump celestia app v0.9.0 #1300
Conversation
@evan-forbes Could you please grant me write access to this branch? I've found solution to one of the problems and want to commit it. |
9fa7035
to
2e6d90b
Compare
6d88a76
to
9cc03b3
Compare
9cc03b3
to
960e7b0
Compare
I've made all tests pass except few that was flaky because of unrelated to PR changes. CI test still could fail due to tests issues that will be fixed in #1314 The problems I've found through tests debugging were:
|
Codecov Report
@@ Coverage Diff @@
## main #1300 +/- ##
==========================================
- Coverage 55.81% 55.23% -0.58%
==========================================
Files 170 176 +6
Lines 10254 10604 +350
==========================================
+ Hits 5723 5857 +134
- Misses 3962 4166 +204
- Partials 569 581 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great finds with the nmt node adder lock and proof proto!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hopefully quick ones
5919a56
bumps to v0.9.0 of celestia-app
this also requires a bump to v0.11.0 of nmt, v0.7.0 of rsmt2d, and v1.4.0 of our fork of the sdk
most of the diff is updating to the new api introduced in rsmt2d and the wrapper
pls feel free to push or edit this branch to fix the remaining bugs