Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modp2p: change user UserAgent name #2932

Closed
Wondertan opened this issue Nov 17, 2023 · 5 comments · Fixed by #3379
Closed

modp2p: change user UserAgent name #2932

Wondertan opened this issue Nov 17, 2023 · 5 comments · Fixed by #3379
Assignees
@ramin
Labels
area:p2p

Comments

@Wondertan
Copy link
Member

Currently, its celestia-<network-name>, which in mainnet it looks like celestia-celestia.We might just trim celestia- prefix.

Related #2908
@ATREAY
Copy link
Contributor

ATREAY commented Nov 21, 2023

Hey @Wondertan, can I work on this issue if you are not currently working on it?

@Wondertan
Copy link
Member Author

Hey @ATREAY, yes, go for it!

The file where this is defined is at nodebuilder/p2p/host.go.
Would be great to fix #2908 as well

@ATREAY
Copy link
Contributor

ATREAY commented Nov 22, 2023 •
edited
Loading

Hey @ATREAY, yes, go for it!

The file where this is defined is at nodebuilder/p2p/host.go. Would be great to fix #2908 as well

Hey @Wondertan, can you give me more details or tell me where I can find information on getting the network version?

@Wondertan
Copy link
Member Author

Wondertan commented Nov 22, 2023 •
edited
Loading

The network version is encoded in the network string. p2p.Nerwork

@ATREAY ATREAY mentioned this issue Nov 24, 2023
Closed
@ATREAY
Copy link
Contributor

ATREAY commented Nov 24, 2023

Hey @Wondertan, I've made the necessary changes. Could you please take a look whenever you have a moment and let me know if any changes are required?

@ramin ramin self-assigned this Dec 6, 2023
@ramin ramin mentioned this issue May 8, 2024
Merged
ramin added a commit that referenced this issue May 10, 2024
@ramin @ATREAY
refactor: changed user UserAgent name (#3379)
86f4b2a 
<!--
Thank you for submitting a pull request!

Please make sure you have reviewed our contributors guide before
submitting your
first PR.

Please ensure you've addressed or included references to any related
issues.

Tips:
- Use keywords like "closes" or "fixes" followed by an issue number to
automatically close related issues when the PR is merged (e.g., "closes
#123" or "fixes #123").
- Describe the changes made in the PR.
- Ensure the PR has one of the required tags (kind:fix, kind:misc,
kind:break!, kind:refactor, kind:feat, kind:deps, kind:docs, kind:ci,
kind:chore, kind:testing)

-->

Opening as a replacement for
#2956 which has gone
stale. I had added some tests to the original refactoring but original
author vanished without allowing admin's to modify the original
PR/branch.

From original note:

fixes: #2932 ,
#2908

---------

Co-authored-by: Atreay Kukanur <66585295+ATREAY@users.noreply.github.com>
@ramin ramin mentioned this issue Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramin ramin

Labels
area:p2p
Projects
None yet
Milestone
No milestone
4 participants
@ramin @Wondertan @renaynay @ATREAY