Increment network version and change default configs #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamsi
reviewed
May 28, 2022
| @@ -572,7 +572,7 @@ func DefaultRPCConfig() *RPCConfig { | |||
| MaxSubscriptionClients: 100, | |||
| MaxSubscriptionsPerClient: 5, | |||
| SubscriptionBufferSize: defaultSubscriptionBufferSize, | |||
| TimeoutBroadcastTxCommit: 10 * time.Second, | |||
| TimeoutBroadcastTxCommit: 35 * time.Second, | |||
config/config.go
Outdated
Comment on lines
774
to
776
| MaxNumInboundPeers: 120, | ||
| MaxNumOutboundPeers: 30, | ||
| MaxConnections: 150, |
There was a problem hiding this comment.
I do not have any confidence in these settings tbh.
There was a problem hiding this comment.
Me either. We can revert these.
There was a problem hiding this comment.
reverted, but fwiw I originally increased because of https://github.com/tharsis/evmos/pull/541/files and osmosis-labs/osmosis#464
| @@ -21,7 +21,7 @@ const ( | |||
| var ( | |||
| // P2PProtocol versions all p2p behavior and msgs. | |||
| // This includes proposer selection. | |||
| P2PProtocol uint64 = 8 | |||
| P2PProtocol uint64 = 9 | |||
There was a problem hiding this comment.
According to @tychoish UseLegacy should be interoperable independent with false/true. I would rather clarify this first before trying to enforce this by bumping the version here.
|
closing as we won't be taking this approach |
cmwaters
pushed a commit
that referenced
this pull request
Sep 20, 2023
Replaced int64 with big.int Co-authored-by: Lasaro <lasaro@informal.systems> Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: Thane Thomson <connect@thanethomson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increments the network version. This will sever the p2p handshake with any node using an older binary. We also take this opportunity to change the default configs, although it should be mentioned that the configs should still be intercepted and changed in the app just to add an extra layer of fool proofness.