Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump github.com/lazyledger/nmt from 0.2.0 to 0.2.1 #214

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 15, 2021

Bumps github.com/lazyledger/nmt from 0.2.0 to 0.2.1.

Release notes

Sourced from github.com/lazyledger/nmt's releases.

v0.2.1

  • Removed panic from IntervalDigestFromBytes (#22)
Commits
  • e0a317a Merge pull request #22 from lazyledger/hlib/digest-validation
  • a5c8085 remove panic from IntervalDigestFromBytes
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/lazyledger/nmt](https://github.com/lazyledger/nmt) from 0.2.0 to 0.2.1.
- [Release notes](https://github.com/lazyledger/nmt/releases)
- [Commits](celestiaorg/nmt@v0.2.0...v0.2.1)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 15, 2021

Dependabot tried to add @melekes, @tessr and @erikgrinaker as reviewers to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/lazyledger/lazyledger-core/pulls/214/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the lazyledger/lazyledger-core repository. // See: https://docs.github.com/rest/reference/pulls#request-reviewers-for-a-pull-request

@dependabot dependabot bot added the T:dependencies Type: Pull requests that update a dependency file label Mar 15, 2021
@liamsi
Copy link
Member

liamsi commented Mar 15, 2021

Despite the new version number, this release is actually API-breaking. Hence, it requires manual work to update to this version. I'll close this in favor of a manual PR that also fixes the places where the type IntervalDigest is used.
ref: celestiaorg/nmt#22 celestiaorg/nmt#20
(cc @Wondertan )

@liamsi liamsi closed this Mar 15, 2021
@liamsi liamsi deleted the dependabot/go_modules/github.com/lazyledger/nmt-0.2.1 branch March 15, 2021 14:57
@Wondertan
Copy link
Member

Wondertan commented Mar 15, 2021

@liamsi, I was going to update everything within DA consensus PR and actually did that already. If necessary, I can do that in the separate PR though or we can mention the DA PR also closes the issue you've just created. Also, should I retag nmt to 0.3.0 instead, as it's API breaking or we can keep 0.2.1?

@liamsi
Copy link
Member

liamsi commented Mar 15, 2021

Also, should I retag nmt to 0.3.0 instead, as it's API breaking or we can keep 0.2.1?

Next time. No need to retag. I do not think it is currently used by any other project (so I wouldn't worry too much about semver semantics - we should start caring as soon as we tag a 1.0.0 release though) and there will be a 0.3.0 release soon anyway. I should document this in the repo (in contributing.md or sth like this).

was going to update everything within DA consensus PR

Yeah, updating the nmt in that PR is OK, especially as you've done that already. In general, smaller, self-contained PRs are definitely preferred for many reasons. For instance reworking the inner/leaf nodes in the ipld plugin should be in a separate PR though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:dependencies Type: Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants