Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that MsgWirePayForData and MsgPayForData contain at least one MessageShareCommitment #654

Merged
merged 5 commits into from
Aug 28, 2022

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Aug 24, 2022

Partially addresses #620

@rootulp rootulp self-assigned this Aug 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2022

Codecov Report

Merging #654 (19b7d11) into main (ff2d92a) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
+ Coverage   38.45%   38.60%   +0.14%     
==========================================
  Files          19       19              
  Lines        2538     2544       +6     
==========================================
+ Hits          976      982       +6     
  Misses       1476     1476              
  Partials       86       86              
Impacted Files Coverage Δ
x/payment/types/payfordata.go 77.69% <100.00%> (+0.49%) ⬆️
x/payment/types/wirepayfordata.go 65.02% <100.00%> (+0.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rootulp rootulp changed the title Ensure that MsgWirePayForData contains at least one MessageShareCommitment Ensure that MsgWirePayForData and MsgPayForData contains at least one MessageShareCommitment Aug 24, 2022
@rootulp rootulp marked this pull request as ready for review August 24, 2022 01:06
adlerjohn
adlerjohn previously approved these changes Aug 25, 2022
@rootulp rootulp changed the title Ensure that MsgWirePayForData and MsgPayForData contains at least one MessageShareCommitment Ensure that MsgWirePayForData and MsgPayForData contain at least one MessageShareCommitment Aug 26, 2022
evan-forbes
evan-forbes previously approved these changes Aug 26, 2022
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rootulp rootulp dismissed stale reviews from evan-forbes and adlerjohn via dab028f August 26, 2022 13:55
@rootulp
Copy link
Collaborator Author

rootulp commented Aug 26, 2022

Sorry for re-review. Had to merge in main and address a small merge conflict.

@rootulp rootulp merged commit de5cd1d into celestiaorg:main Aug 28, 2022
@rootulp rootulp deleted the rp/validate-basic-all-squares branch August 28, 2022 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants