Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SetGasLimitAndFee should round up #2963

Merged
merged 2 commits into from
Dec 27, 2023
Merged

feat: SetGasLimitAndFee should round up #2963

merged 2 commits into from
Dec 27, 2023

Conversation

cmwaters
Copy link
Contributor

As was the case with the txsim, converting to int64 can occasionally truncate the value meaning that the tx has actually a lower gas price

Copy link
Contributor

coderabbitai bot commented Dec 27, 2023

Walkthrough

Walkthrough

The update involves enhancing the gas price calculation in a transaction options configuration file by importing the math package and refining the SetGasLimitAndFee function. This function now uses sdk.NewInt64Coin for a more precise handling of gas price figures.

Changes

File Change Summary
pkg/user/tx_options.go Imported math package; modified SetGasLimitAndFee to use sdk.NewInt64Coin for gas price calculation.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat with CodeRabbit Bot (@coderabbitai)

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your comments unless it is explicitly tagged.

  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
    • @coderabbitai generate unit tests for this file
    • @coderabbitai modularize this function
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
    • @coderabbitai gather interesting statistics about this repository and render them in a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai generate unit tests for the src/utils.ts file.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@celestia-bot celestia-bot requested a review from a team December 27, 2023 00:17
@cmwaters cmwaters added the backport:v1.x PR will be backported automatically to the v1.x branch upon merging label Dec 27, 2023
@cmwaters cmwaters merged commit ea1a92d into main Dec 27, 2023
31 checks passed
@cmwaters cmwaters deleted the cal/round-up-fee branch December 27, 2023 07:28
mergify bot pushed a commit that referenced this pull request Dec 27, 2023
As was the case with the txsim, converting to int64 can occasionally
truncate the value meaning that the tx has actually a lower gas price

(cherry picked from commit ea1a92d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:v1.x PR will be backported automatically to the v1.x branch upon merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants