Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: resource pricing specs #2132

Merged
merged 10 commits into from
Jul 27, 2023
Merged

docs: resource pricing specs #2132

merged 10 commits into from
Jul 27, 2023

Conversation

evan-forbes
Copy link
Member

@evan-forbes evan-forbes commented Jul 19, 2023

Overview

Added resource pricing specs/docs.

rendered

closes #940

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@github-actions
Copy link

github-actions bot commented Jul 19, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://celestiaorg.github.io/celestia-app/pr-preview/pr-2132/
on branch gh-pages at 2023-07-26 07:30 UTC

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Merging #2132 (a1c1dc2) into main (7494cc7) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2132   +/-   ##
=======================================
  Coverage   24.41%   24.41%           
=======================================
  Files         126      126           
  Lines       14300    14300           
=======================================
  Hits         3491     3491           
  Misses      10448    10448           
  Partials      361      361           

@evan-forbes evan-forbes self-assigned this Jul 24, 2023
@evan-forbes evan-forbes changed the title [WIP] docs: init resource pricing [WIP] docs: resource pricing specs Jul 25, 2023
@evan-forbes
Copy link
Member Author

evan-forbes commented Jul 25, 2023

opened #2161 for the txsim issues

@evan-forbes evan-forbes marked this pull request as ready for review July 25, 2023 12:16
@evan-forbes evan-forbes changed the title [WIP] docs: resource pricing specs docs: resource pricing specs Jul 25, 2023
@evan-forbes evan-forbes added the specs directly relevant to the specs label Jul 25, 2023
rootulp
rootulp previously approved these changes Jul 25, 2023
specs/src/specs/resource_pricing.md Outdated Show resolved Hide resolved
specs/src/specs/resource_pricing.md Outdated Show resolved Hide resolved
specs/src/specs/resource_pricing.md Outdated Show resolved Hide resolved
specs/src/specs/resource_pricing.md Outdated Show resolved Hide resolved
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would defer to other reviewers for approval.

specs/src/specs/resource_pricing.md Show resolved Hide resolved
specs/src/specs/resource_pricing.md Show resolved Hide resolved
specs/src/specs/resource_pricing.md Show resolved Hide resolved
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
Co-authored-by: Rootul P <rootulp@gmail.com>
@MSevey MSevey requested a review from a team July 26, 2023 07:22
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evan-forbes evan-forbes merged commit 51ee580 into main Jul 27, 2023
25 of 27 checks passed
@evan-forbes evan-forbes deleted the evan/gas-specs-2 branch July 27, 2023 09:16
@evan-forbes evan-forbes added the backport:v1.x PR will be backported automatically to the v1.x branch upon merging label Sep 5, 2023
mergify bot pushed a commit that referenced this pull request Sep 5, 2023
## Overview

Added resource pricing specs/docs.

[rendered](https://github.com/celestiaorg/celestia-app/blob/2a4ef9c9f3c276dfc514466bce9be24434d53189/specs/src/specs/resource_pricing.md)

closes #940

## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords

---------

Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
Co-authored-by: Rootul P <rootulp@gmail.com>
(cherry picked from commit 51ee580)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:v1.x PR will be backported automatically to the v1.x branch upon merging specs directly relevant to the specs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify gas costs
5 participants