feat: use knuu for PoC e2e test #1914
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1914 +/- ##
==========================================
- Coverage 25.02% 24.26% -0.76%
==========================================
Files 121 125 +4
Lines 13806 14238 +432
==========================================
Hits 3455 3455
- Misses 9995 10427 +432
Partials 356 356
|
|
@cmwaters proto-gen is failing. Perhaps this PR needs a |
There was a problem hiding this comment.
This e2e framework is supposed to take the place of the previous e2e framework, right?
Are there any instructions to run? As rootul said, it's a testing framework, we could merge and iterate on it later. But I would prefer to have a version that anyone can run before merging it. So, instructions, even if only the basics, are important before merging this
| ) | ||
|
|
||
| const ( | ||
| latestVersion = "v1.0.0-rc9" |
There was a problem hiding this comment.
So this e2e will not run latest master, but instead the specified release branch?
There was a problem hiding this comment.
Yeah, so far it has to retrieve the image from github (i.e. the docker image needs to be published first). It would be nice if we could just build the image for the current branch locally as a means of testing against. Something to follow up with later
There was a problem hiding this comment.
Cool. I guess it would make sense to create an issue for this as an improvement
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
This PR integrates the knuu e2e testing fixture. It includes a simple 4 validator test