Integration test for querying malleated transactions #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
changed the title
adlerjohn
reviewed
Jan 20, 2022
Unfortunately, I don't think there is. We are already blocking until the tx is included in a block, it just takes a very small amount of time before the tx is indexed. On my local machine, this can be as small as 10ms. Hopefully the overly large wait time avoids flakiness.
👍 a1b1cab
removed, and will add in a different PR efa34ac |
liamsi
previously approved these changes
Jan 22, 2022
This reverts commit 3de8af6.
evan-forbes
force-pushed
the
evan/integration-test-for-query
branch
from
a1b1cab
to
cb80736
Compare
Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
adlerjohn
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the integration test to also query for the malleated transaction using the original transaction's hash.
blocked by #612