-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: override TxDecoder #1666
fix: override TxDecoder #1666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo we should also remove all the other instance of the index wrapper tx decoder and exclusively rely on the encoding config, and then unexport the index wrapper tx decoder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Wondering shouldn't this be marked as a breaking change?
Update: Skip my question, the prior behaviour was a bug and the current one is the correct one, so no breaking change!
Codecov Report
@@ Coverage Diff @@
## main #1666 +/- ##
=======================================
Coverage 51.56% 51.56%
=======================================
Files 95 95
Lines 5954 5954
=======================================
Hits 3070 3070
Misses 2570 2570
Partials 314 314
|
Just FYI, I'm working on a prototype to have |
Closes #1620
Closes #1665
Testing