Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce --namespace-version CLI flag #1528

Closed
rootulp opened this issue Mar 23, 2023 · 0 comments · Fixed by #1585
Closed

Introduce --namespace-version CLI flag #1528

rootulp opened this issue Mar 23, 2023 · 0 comments · Fixed by #1585
Labels
enhancement New feature or request

Comments

@rootulp
Copy link
Collaborator

rootulp commented Mar 23, 2023

Similar to #1041 but for the namespace version introduced as part of #1434
@rootulp rootulp added the enhancement New feature or request label Mar 23, 2023
@amityadav0 amityadav0 mentioned this issue Mar 31, 2023
Merged
evan-forbes added a commit that referenced this issue Apr 19, 2023
@amityadav0 @rootulp @evan-forbes
feat: Introduce --namespace-version CLI flag (#1585)
d88adf7 
## Overview

Introduce --namespace-version CLI flag 
- Closes #1528 

I have introduced namespace flag. Currently this supports namespace
version zero only.
I think data structure for storing namespace versions can be updated.
Maybe a map with version details.
For example:
```
Key: Version[0], Value: { NamespaceVersionPrefixSize: ... , NamespaceVersionIDSize: ... }
Key: Version[1], Value: { NamespaceVersionPrefixSize: ... , NamespaceVersionIDSize: ... }
```
instead of constants
```
	NamespaceVersionZero = uint8(0)
	NamespaceVersionZeroPrefixSize = 22
	NamespaceVersionZeroIDSize = NamespaceIDSize - NamespaceVersionZeroPrefixSize
```

Then it would be possible to switch versions easily from cli. same for
share version.

Please let me know if this makes sense or am I missing something.

---------

Co-authored-by: Rootul P <rootulp@gmail.com>
Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
Co-authored-by: evan-forbes <evan.samuel.forbes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Introduce --namespace-version CLI flag amityadav0/celestia-app
1 participant
@rootulp