bug: fix handling of variables in conditions #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSevey
changed the title
Bidon15
approved these changes
Oct 13, 2023
Wondertan
pushed a commit
to celestiaorg/celestia-node
that referenced
this pull request
Oct 13, 2023
Final bug fix celestiaorg/.github#82 Visual proof of action executing as expected now celestiaorg/celestia-node/actions/runs/6509222904/job/17680437495 Screen Shot 2023-10-13 at 10 13 28 AM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Here is the debug log:
The variables that we were creating were assumed boolean types because when printed they are
trueandfalse. However by checking the values against boolean and string representations, we can see that the variables are indeed strings. This resulted in the logical if statements always being evaluated totruebecause if a string is not""then it is true.