Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Rootul P <rootulp@gmail.com>
  • Loading branch information
MSevey and rootulp committed Feb 5, 2024
1 parent c401f4d commit 3f125b7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/dockerfile_workflow_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# to build and push the Docker image to the container registries.
#
# The reason this workflow targets the develop branch is so that we can test the
# action in the PR. If we targeted main, we would need to merge changes into
# action in the PR. If we targeted main, we would need to merge changes in
# before being able to test them.
#
name: Build Using Reusable Workflow
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable_dockerfile_pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ jobs:
steps:
- name: Check run conditions
id: run_check
# We only want to run when the registry is able to run on pr or if it is a merge event
# We only want to run when the registry is able to run on PR or if it is a merge event
run: echo "run=${{ matrix.registry.run-on-pr == needs.prepare-env.outputs.build_for_pr || needs.prepare-env.outputs.build_for_merge == 'true'}}" >> "$GITHUB_OUTPUT"

- name: Checkout
Expand Down

0 comments on commit 3f125b7

Please sign in to comment.