enhance: allow uses to disable broker heartbeats by not providing a timeout (#1997,#1998) #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
approved these changes
Jun 1, 2024
FrankK-1234
added a commit
to FrankK-1234/kombu
that referenced
this pull request
Sep 5, 2024
auvipy
pushed a commit
that referenced
this pull request
Sep 5, 2024
ivanprjcts
added a commit
to ivanprjcts/kombu
that referenced
this pull request
Sep 14, 2024
…ding a timeout (celery#2097, celery#2016)" This reverts commit 33490ad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I took the liberty to add a test case for #1998. I was not able to add to that request so created (upon advise) a new PR with the change in it as well. The original change was done by @smart-programmer and resolves #1997. Hopefully this is enough to close the issues (this, #1997 and #1998).
I basically verified if the heartbeat_check is called/not called based upon the timeout value.