Add solar schedules #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Migrations fail because the |
|
rebase and try to fix the errors |
|
@auvipy ok this is cleaned up now |
ask
reviewed
Dec 8, 2016
| """Table information.""" | ||
|
|
||
| verbose_name = _('solar') | ||
| verbose_name_plural = _('solars') |
There was a problem hiding this comment.
maybe this should be 'solar event' and 'solar events'?
There was a problem hiding this comment.
should probably also have unique_together = ('event', 'latitude' ,'longitude') here?
There was a problem hiding this comment.
sounds good to me, thanks ask :)
There was a problem hiding this comment.
sorry @ask, i forgot to check travis last night. the unique_together has been added.
ask
approved these changes
Dec 9, 2016
| """Table information.""" | ||
|
|
||
| verbose_name = _('solar') | ||
| verbose_name_plural = _('solars') |
There was a problem hiding this comment.
should probably also have unique_together = ('event', 'latitude' ,'longitude') here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response for #8. I'm not sure what you want the names to be ("solars" for
verbose_name_pluralseems odd, for example). It uses the event names directly fromcelery.schedules.solar, so the model doesn't have any constants. Is it safe to redefine them here?