feat: add periodic_task_name in favor of celery/django-celery-results#261 #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvelvee
changed the title
auvipy
reviewed
Dec 15, 2021
auvipy
requested changes
Dec 16, 2021
docs/includes/introduction.txt
Outdated
| ----------------------------------- | ||
|
|
||
| Now you can store PeriodicTask.name to django-celery-results (TaskResult.periodic_task_name). | ||
| (more details here: https://github.com/celery/django-celery-beat/pull/477, https://github.com/celery/django-celery-results/pull/261) |
There was a problem hiding this comment.
i think we should add more text and example with the links provided
There was a problem hiding this comment.
added, but i'm not familiar with .rst files, may you help to check it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
celery/django-celery-results#261
Now you can store PeriodicTask.name to django-celery-results (TaskResult.periodic_task_name).
Suppose we have two periodic tasks, their schedules are different, but the tasks are the same.
Now you can distinguish the source of the task from the results by the
periodic_task_namefield.celery beat will add PeriodicTask.name to requests when scheduled by database or manually scheduled by admin panel.