Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add naming capability to tasks #213

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Add naming capability to tasks #213

merged 2 commits into from
Sep 28, 2023

Conversation

GagaLP
Copy link
Contributor

@GagaLP GagaLP commented Sep 12, 2023

This adds naming to tasks similar to buffer naming.

@github-actions
Copy link

Check-perf-impact results: (7a518c63eb0655471fea6a4902fc0af7)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

Copy link
Contributor

@fknorr fknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good overall but could use a bit of polishing.

test/debug_naming_tests.cc Outdated Show resolved Hide resolved
test/debug_naming_tests.cc Outdated Show resolved Hide resolved
test/debug_naming_tests.cc Outdated Show resolved Hide resolved
test/debug_naming_tests.cc Outdated Show resolved Hide resolved
include/handler.h Outdated Show resolved Hide resolved
@GagaLP GagaLP force-pushed the debug_task_names branch 3 times, most recently from 09cb20d to e57deaf Compare September 14, 2023 10:00
Copy link
Contributor

@fknorr fknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@psalz psalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

include/task.h Outdated Show resolved Hide resolved
test/debug_naming_tests.cc Show resolved Hide resolved
@psalz psalz merged commit cde3587 into master Sep 28, 2023
@psalz psalz deleted the debug_task_names branch September 28, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants